maropu commented on a change in pull request #25242: [SPARK-28497][SQL]
Disallow upcasting complex data types to string type
URL: https://github.com/apache/spark/pull/25242#discussion_r306846586
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -131,7 +131,8 @@ object Cast {
case (from: DecimalType, to: NumericType) if from.isTighterThan(to) => true
case (f, t) if legalNumericPrecedence(f, t) => true
case (DateType, TimestampType) => true
- case (_, StringType) => true
+ case (_: AtomicType, StringType) => true
+ case (_: CalendarIntervalType, StringType) => true
Review comment:
Yup, I also think the case is not valid. So, my question is just that the
cast is accepted before this pr? If so, it might be better to add tests for
that, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
