cloud-fan commented on a change in pull request #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test URL: https://github.com/apache/spark/pull/25243#discussion_r306902689
########## File path: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-joins.sql.out ########## @@ -106,8 +106,8 @@ ORDER BY t1a DESC, t3b DESC -- !query 4 schema struct<count(DISTINCT t1a):bigint,t1b:smallint,t3a:string,t3b:smallint,t3c:int> -- !query 4 output -1 10 val3b 8 NULL 1 10 val1b 8 16 +1 10 val3b 8 NULL Review comment: Previously, `TestSparkSession.newSession` creates a `SparkSession`, which won't set `SHUFFLE_PARTITIONS` to 5. This can change the result order of queries that has shuffles. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
