vanzin commented on a change in pull request #22290: [SPARK-25285][CORE] Add
startedTasks and finishedTasks to the metrics system in the executor instance
URL: https://github.com/apache/spark/pull/22290#discussion_r307047573
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -556,6 +556,8 @@ private[spark] class Executor(
}
}
+ // update metric counting the number of tasks finished
+ executorSource.FINISHED_TASKS.inc(1L)
Review comment:
Since you're making a point to expose this metric separately from the
already existing "completeTasks", it probably should be named "succeededTasks"
to emphasize the difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
