HeartSaVioR commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307087380
########## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceProviderSuite.scala ########## @@ -22,60 +22,99 @@ import java.util.Locale import scala.collection.JavaConverters._ import org.mockito.Mockito.{mock, when} -import org.scalatest.{BeforeAndAfterEach, PrivateMethodTester} +import org.scalatest.{PrivateMethodTester} import org.apache.spark.{SparkConf, SparkEnv, SparkFunSuite} import org.apache.spark.sql.sources.v2.reader.Scan import org.apache.spark.sql.util.CaseInsensitiveStringMap class KafkaSourceProviderSuite extends SparkFunSuite with PrivateMethodTester { + private val expected = "1111" private val pollTimeoutMsMethod = PrivateMethod[Long]('pollTimeoutMs) private val maxOffsetsPerTriggerMethod = PrivateMethod[Option[Long]]('maxOffsetsPerTrigger) + private val maxOffsetFetchAttemptsMethod = PrivateMethod[Int]('maxOffsetFetchAttempts) Review comment: If we would like to allow their scope as non-private for testing, I'll take care of this after merging. @gaborgsomogyi is on vacation (as he mentioned in other PR) so it would take couple of weeks when we would like to add the change on the scope of this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org