HeartSaVioR commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r307124628
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaRelationSuite.scala
##########
@@ -158,19 +157,21 @@ abstract class KafkaRelationSuiteBase extends QueryTest
with SharedSQLContext wi
val topic = newTopic()
testUtils.createTopic(topic, partitions = 3)
testUtils.sendMessage(
- topic, ("1", Array(("once", "1".getBytes), ("twice", "2".getBytes))),
Some(0)
+ topic, ("1", Seq()), Some(0)
)
testUtils.sendMessage(
- topic, ("2", Array(("once", "2".getBytes), ("twice", "4".getBytes))),
Some(1)
+ topic, ("2", Seq(("a", "b".getBytes("UTF-8")), ("c",
"d".getBytes("UTF-8")))), Some(1)
Review comment:
I would be happy to deal with cleaning up. Just want to avoid adding more
for what Spark seems to use less. (I sought with ".getBytes" and
StandardCharsets.UTF_8 is used majorly.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
