maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307546401
########## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ########## @@ -1,5 +1,5 @@ -- Automatically generated by SQLQueryTestSuite --- Number of queries: 27 +-- Number of queries: 63 Review comment: IMHO its ok to support minimal syntaxes for `WITH RECURSIVE` in this pr because the most controversial part in this pr is the implementation of `RecursiveTableExec` about how spark should execute recursive queries. In this pr, it would be better to concentrate on the discussion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
