Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3872#discussion_r23066523
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
    @@ -383,6 +383,19 @@ private[hive] class HiveMetastoreCatalog(hive: 
HiveContext) extends Catalog with
       override def unregisterTable(tableIdentifier: Seq[String]): Unit = ???
     
       override def unregisterAllTables() = {}
    +
    +  // Necessary helper method so showTables can return Array[String] vs List
    +  private def convertToArray(tables: java.util.List[String]): 
Array[String] = {
    +    new Array[String](tables.length)
    --- End diff --
    
    This doesn't actually convert the list to an array, does it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to