Github user ScrapCodes commented on the pull request:

    https://github.com/apache/spark/pull/4043#issuecomment-70220772
  
    LinkedHashMap was introduced to maintain the insertion order of 
stagesIds(Hasmap will lead to arbitrary order), all map(s) in scala has return 
an `Option` on `remove` behavior. Even in java calling remove on inexistent key 
returns null. Do you still want me to change it? Also may be changing the name 
pendingStages to pendingStagesMap will avoid that confusion ? and should the 
same apply to - already existing field activeStages ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to