Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/3200#issuecomment-70317456
  
    @brkyvz  Those are my only comments for now, except that the tests could 
also check that partitioner has the right info.
    
    Also, I wonder if it would be better to force the RDD partitioner to be a 
grid partitioner and to use that partitioner, rather than storing a new 
instance of the partitioner (which must be kept in synch with the actual 
partitioner).  Users could construct block matrices via methods we provide, 
which would set up the RDD with the right partitioner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to