srowen commented on a change in pull request #25279: [WIP][SPARK-28519][SQL]
Use StrictMath log, pow functions for platform independence
URL: https://github.com/apache/spark/pull/25279#discussion_r308762550
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -486,7 +483,7 @@ case class Factorial(child: Expression) extends
UnaryExpression with ImplicitCas
> SELECT _FUNC_(1);
0.0
""")
-case class Log(child: Expression) extends UnaryLogExpression(math.log, "LOG")
+case class Log(child: Expression) extends UnaryLogExpression(StrictMath.log,
"LOG")
Review comment:
OK will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
