mgaido91 commented on a change in pull request #21599: [SPARK-26218][SQL]
Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#discussion_r308796542
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
##########
@@ -89,5 +92,11 @@ case class Sum(child: Expression) extends
DeclarativeAggregate with ImplicitCast
)
}
- override lazy val evaluateExpression: Expression = sum
+ override lazy val evaluateExpression: Expression = {
+ if (sumDataType == resultType) {
+ sum
+ } else {
+ Cast(sum, resultType)
Review comment:
I see. I agree. Shall we revert this change here and do this in another PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
