dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL]
Support ANSI SQL Boolean-Predicate syntax
URL: https://github.com/apache/spark/pull/25074#discussion_r308826933
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -840,3 +840,85 @@ case class GreaterThanOrEqual(left: Expression, right:
Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any =
ordering.gteq(input1, input2)
}
+
+trait BooleanTest extends UnaryExpression with Predicate with
ExpectsInputTypes {
+
+ def boolValue: Boolean
+ def whenNull: Boolean
Review comment:
+1 for `boolValueWhenNull`. For the other, `boolValueForComparison` might be
better instead of `boolValueForTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
