yeshengm commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r308925013
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ga/JoinReorderGA.scala ########## @@ -0,0 +1,65 @@ +/* Review comment: Do we really want it to be in a separate package `ga`? It's kinda overkill for me. I'd suggest that we put all these `ga`-related stuff in a single file `JoinReorderGA`. For historical reasons, `JoinReorderDP` was put in `CostBasedJoinReorder`... But we just want to be consistent in that a rule remains in a single file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
