gatorsmile commented on a change in pull request #25294: [SPARK-28476][SQL]
Support ALTER DATABASE SET LOCATION
URL: https://github.com/apache/spark/pull/25294#discussion_r309527041
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
##########
@@ -184,6 +184,15 @@ class DDLParserSuite extends AnalysisTest with
SharedSQLContext {
containsThesePhrases = Seq("key_without_value"))
}
+ test("alter database set location") {
+ // ALTER (DATABASE|SCHEMA) database_name SET LOCATION
+ val sql1 = "ALTER DATABASE database_name SET LOCATION '/home/user/db'"
Review comment:
1. A database that does not exist before issuing this command?
2. Setting an illegal path that could trigger an exception inside the
function `stringToURI`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
