cloud-fan commented on a change in pull request #25115: [SPARK-28351][SQL]
Support DELETE in DataSource V2
URL: https://github.com/apache/spark/pull/25115#discussion_r309746752
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -541,6 +541,15 @@ object OverwritePartitionsDynamic {
}
}
+case class DeleteFromTable(
+ child: LogicalPlan,
+ condition: Filter)
+ extends Command {
+
+ override def children: Seq[LogicalPlan] = child :: condition :: Nil
Review comment:
How does it pass compilation? `condition` is not a logical plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
