Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/3997#discussion_r23139673
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -51,13 +51,35 @@ sealed trait Vector extends Serializable {
override def equals(other: Any): Boolean = {
other match {
- case v: Vector =>
- util.Arrays.equals(this.toArray, v.toArray)
+ case v2: Vector => {
+ if (this.size != v2.size) return false
+ (this, v2) match {
+ case (s1: SparseVector, s2: SparseVector) =>
+ Vectors.getEquality(s1.indices, s1.values, s2.indices,
s2.values)
+ case (s1: SparseVector, d1: DenseVector) =>
+ Vectors.getEquality(s1.indices, s1.values, 0 until d1.size,
d1.values)
+ case (d1: DenseVector, s1: SparseVector) =>
+ Vectors.getEquality(0 until d1.size, d1.values, s1.indices,
s1.values)
+ case (_, _) => util.Arrays.equals(this.toArray, v2.toArray)
--- End diff --
Thanks for review, @srowen
Yes, I can change the name. Just like the name in `util.Arrays.equals`.
And for the catch-all case, I was thinking `util.Arrays.equals` is also
fail-fast and it can cover the dense vs dense case well, and with some
extensiblity. Maybe I don't catch your point. Let me know if still we should
change this. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
