xuanyuanking commented on a change in pull request #25333: [SPARK-28597][SS]Spark streaming terminated when close meta data log error URL: https://github.com/apache/spark/pull/25333#discussion_r310367408
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ########## @@ -114,12 +116,16 @@ class HDFSMetadataLog[T <: AnyRef : ClassTag](sparkSession: SparkSession, path: } } - /** Write a batch to a temp file then rename it to the batch file. - * - * There may be multiple [[HDFSMetadataLog]] using the same metadata path. Although it is not a - * valid behavior, we still need to prevent it from destroying the files. - */ private def writeBatchToFile(metadata: T, path: Path): Unit = { + writeBatchToFileWithRetries(metadata, path, 1) + } + + /** Write a batch to a temp file then rename it to the batch file. + * Review comment: nit: indent, use the java style comment here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org