dongjoon-hyun edited a comment on issue #25229: [SPARK-27900][K8s] Add jvm oom flag URL: https://github.com/apache/spark/pull/25229#issuecomment-518916061 @skonto . My name is `Dongjoon Hyun` with GitHub id `@dongjoon-hyun`. :) I knew the history of #24796 and Spark uses `YarnSparkHadoopUtil.addOutOfMemoryErrorArgument`. I agree with the necessity of this since that PR, and tried to review/merge this PR. However, the current implementation seems a little too complicated and not robust, especially the part of copying `/opt/spark/conf/spark.properties` to `/tmp/spark.properties` and replacing it. In general, I believe the best UX is to keep it simple by reusing the existing general one. `OnOutOfMemoryError` is a well-known option for JVM users and `spark.driver.extraJavaOptions` is for that kind of option. As of now, I prefer a new documentation, but other committers may have different opinions. Let me ping them to get their advice. Hi, @srowen , @squito , @mccheah , @zsxwing , @tgravescs . This is the continuation of #24796 . Could you review this PR's implementation in order to make a progress and finalize the issue?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
