brkyvz commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311656333
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ########## @@ -200,24 +202,37 @@ object DataSourceV2Strategy extends Strategy with PredicateHelper { catalog, ident, parts, + query, planLater(query), props, writeOptions, orCreate = orCreate) :: Nil } case AppendData(r: DataSourceV2Relation, query, _) => - AppendDataExec(r.table.asWritable, r.options, planLater(query)) :: Nil Review comment: because table creation happens after certain operations with side effects in CTAS and RTAS. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org