brkyvz commented on a change in pull request #25368: [SPARK-28635][SQL] create
CatalogManager to track registered v2 catalogs
URL: https://github.com/apache/spark/pull/25368#discussion_r312664363
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -196,12 +199,10 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSQLContext with BeforeAn
}
test("CreateTable: use default catalog for v2 sources when default catalog
is set") {
- val sparkSession = spark.newSession()
- sparkSession.conf.set("spark.sql.catalog.testcat",
classOf[TestInMemoryTableCatalog].getName)
- sparkSession.conf.set("spark.sql.default.catalog", "testcat")
- sparkSession.sql(s"CREATE TABLE table_name (id bigint, data string) USING
foo")
+ spark.conf.set("spark.sql.default.catalog", "testcat")
Review comment:
`withSQLConf`? Otherwise you affect all tests below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
