advancedxy commented on a change in pull request #25398: [SPARK-28659][SQL] Use
data source if convertible in insert overwrite directory
URL: https://github.com/apache/spark/pull/25398#discussion_r312816718
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -1396,6 +1396,17 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
compressed = false,
properties = rowStorage.properties ++ fileStorage.properties)
- (ctx.LOCAL != null, storage, Some(DDLUtils.HIVE_PROVIDER))
+ val fileFormat = extractFileFormat(fileStorage.serde)
+ (ctx.LOCAL != null, storage, Some(fileFormat))
+ }
+
+ private def extractFileFormat(serde: Option[String]): String = {
+ if (serde.toString.contains("parquet")) {
Review comment:
Although `None.toString` is `"None"`, this looks like a hack to me.
How about:
```
serde.map({ x =>
val lowerCaseSerde = x.toLowerCase(Locale.ROOT)
if (lowerCaseSerde.contains("parquet") "parquet"
else if (lowerCaseSerde.contains("orc") "orc"
else DDLUtils.HIVE_PROVIDER
}).getOrElse( DDLUtils.HIVE_PROVIDER)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
