Github user mccheah commented on the pull request:
https://github.com/apache/spark/pull/4066#issuecomment-70723749
Did you think of any corner cases that you might have missed? In terms of
correctness, this seems okay (although the Jenkins build indicates there are
some issues). Have you thought about testing? I'm trying to brainstorm how to
unit test this as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
