MaxGekk commented on a change in pull request #25408: [SPARK-28687][SQL]
Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`
URL: https://github.com/apache/spark/pull/25408#discussion_r313499704
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1426,6 +1428,12 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
Minute(expression(ctx.source))
case "SECOND" =>
Second(expression(ctx.source))
+ case "MILLISECONDS" | "MSEC" =>
Review comment:
> Did you check PostgreSQL to find out all supported variants?
I checked PostgreSQL documentation and JIRA ticket that mention
`milliseconds` only. As far as I see `timestamp.sql` uses `msec` / `msec` as
well.
> at least, MS and MSECS are missing here.
Do we need to support them if they are not used in tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
