zsxwing commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer URL: https://github.com/apache/spark/pull/24382#discussion_r313538580
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSuite.scala ########## @@ -286,6 +293,71 @@ object ForeachWriterSuite { } } +class ForeachWriterAbortSuite extends StreamTest with SharedSQLContext with BeforeAndAfter { Review comment: > i wanted to create a test that will simulate a use case in which the abort is called when the writer has not been closed yet `df.map(_ / 0)` will trigger the above behavior. Right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org