HyukjinKwon commented on a change in pull request #25443: 
[WIP][SPARK-28723][test-hadoop3.2][test-maven] Test JDK 11 with Hadoop-3.2/Hive 
2.3.6 on jenkins
URL: https://github.com/apache/spark/pull/25443#discussion_r313699994
 
 

 ##########
 File path: dev/run-tests-jenkins
 ##########
 @@ -31,4 +31,7 @@ if [[ "$PYTHON_VERSION_CHECK" == "True" ]]; then
   exit -1
 fi
 
+export JAVA_HOME=/usr/java/jdk-11.0.1
+export PATH=${JAVA_HOME}/bin:${PATH}
 
 Review comment:
   @wangyum, can you try this?
   
   Seems we should pass env at
   
   
https://github.com/apache/spark/pull/25423/files#diff-3c9f4fccf7d30ce2e8fa86db2ad1fdadR124
   
   ```diff
   diff --git a/dev/run-tests-jenkins.py b/dev/run-tests-jenkins.py
   index 4b91a5fa423..7a73657138f 100755
   --- a/dev/run-tests-jenkins.py
   +++ b/dev/run-tests-jenkins.py
   @@ -121,7 +121,8 @@ def run_tests(tests_timeout):
   
        test_result_code = subprocess.Popen(['timeout',
                                             tests_timeout,
   -                                         os.path.join(SPARK_HOME, 'dev', 
'run-tests')]).wait()
   +                                         os.path.join(SPARK_HOME, 'dev', 
'run-tests')],
   +                                        env=dict(os.environ)).wait()
   ```
   
   Seems like there's something wrong when environment variables are inherited 
(by default).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to