dilipbiswal commented on a change in pull request #24759: 
[SPARK-27395][SQL][WIP] Improve EXPLAIN command
URL: https://github.com/apache/spark/pull/24759#discussion_r313532384
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
 ##########
 @@ -530,7 +531,10 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] 
extends Product {
     s"$nodeName ${argString(maxFields)}".trim
   }
 
-  /** ONE line description of this node with more information */
+  def simpleString(
+     planToOperatorID: mutable.LinkedHashMap[QueryPlan[_], Int]): String = 
s"$nodeName".trim
 
 Review comment:
   @cloud-fan I agree. Actually i tried very hard to place the new methods in 
QueryPlan and keep TreeNode untouched. But couldn't do it as i was operating 
with a premise to not modify the plan in anyway. But your subsequent comment to 
use tagging to store the operatorid temporarily in the plan may help. Let me 
think about this a bit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to