shaneknapp commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521337980 hmmm. i think i might be approaching this the wrong way for the PRB build. if we want to build w/java 8 and test w/java 11, then i think that i won't actually need to change anything in `dev/run-tests.py` and `dev/run-tests-jenkins.py`. instead, after taking a second look at the SparkPullRequestBuilder config on jenkins, i noticed that after it calls `dev/run-tests-jenkins`, the build executes `./build/sbt unsafe/test > /dev/null`. if `sbt unsafe/test` is what's actually performing the tests, then all we need to do is add `-Djava-version=11` to `$SBT_OPTS` when the test-java11 flag is in the PR title. thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
