srowen commented on a change in pull request #25470: [SPARK-28751][Core]
Improve java serializer deserialization performance
URL: https://github.com/apache/spark/pull/25470#discussion_r314800393
##########
File path: core/src/main/scala/org/apache/spark/serializer/JavaSerializer.scala
##########
@@ -92,9 +106,14 @@ private object JavaDeserializationStream {
}
private[spark] class JavaSerializerInstance(
- counterReset: Int, extraDebugInfo: Boolean, defaultClassLoader:
ClassLoader)
+ counterReset: Int,
+ extraDebugInfo: Boolean,
+ defaultClassLoader: ClassLoader,
+ useCache: Boolean)
extends SerializerInstance {
+ lazy val resolvedClassesCache = new ConcurrentHashMap[(String, ClassLoader),
Class[_]]()
Review comment:
Also, how big might this map get? I suppose its lifetime is limited, and
won't cache just massive numbers of classes, hm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
