srowen commented on a change in pull request #22282: [SPARK-23539][SS] Add
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r314830320
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
##########
@@ -88,7 +92,19 @@ private[kafka010] abstract class KafkaRowWriter(
throw new NullPointerException(s"null topic present in the data. Use the
" +
s"${KafkaSourceProvider.TOPIC_OPTION_KEY} option for setting a default
topic.")
}
- val record = new ProducerRecord[Array[Byte], Array[Byte]](topic.toString,
key, value)
+ val record = if (projectedRow.isNullAt(3)) {
+ new ProducerRecord[Array[Byte], Array[Byte]](topic.toString, null, key,
value)
+ } else {
+ val headerArray = projectedRow.getArray(3)
+ val headers = (0 until headerArray.numElements()).map(
+ i => {
+ val struct = headerArray.getStruct(i, 2)
+ new RecordHeader(struct.getUTF8String(0).toString,
struct.getBinary(1))
+ .asInstanceOf[Header]
Review comment:
Do you need this cast? it's already a `Header`? I could be missing something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
