sarutak opened a new pull request #25484: [SPARK-28647][WEBUI] Recover 
additional metric feature for branch-2.4
URL: https://github.com/apache/spark/pull/25484
 
 
   This PR is for backporting SPARK-28647 to branch-2.4.
   The original PR removed `additional-metrics.js` but branch-2.4 still use it 
so I don't remove it and related things for branch-2.4.
   
   ### What changes were proposed in this pull request?
   Added checkboxes to enable users to select which additional metrics (`On 
Heap Memory`, `Off Heap Memory` and `Select All` in this case) to be shown in 
`ExecuorPage`. 
   
   ### Why are the changes needed?
   By SPARK-17019, `On Heap Memory` and `Off Heap Memory` are introduced as 
optional metrics. But they are not displayed because they are made `display: 
none` in css and there are no way to appear them.
   
   ### Does this PR introduce any user-facing change?
   The previous `ExecutorPage` doesn't show additional metrics.
   This change adds checkboxes to `ExecutorPage` for additional metrics.
   We can choose which metrics should be shown by checking corresponding 
checkboxes.
   ![Screenshot from 2019-08-18 
03-56-09](https://user-images.githubusercontent.com/4736016/63216148-2bfadb80-c16c-11e9-81e1-e1e66198dd6c.png)
   
   
   ### How was this patch tested?
   Manual test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to