HyukjinKwon edited a comment on issue #22570: [SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config URL: https://github.com/apache/spark/pull/22570#issuecomment-522324073 If we turn to `warn`, then we won't have to change a lot of instances here, Yes. But one concern is though then it will show 1000 lines of warnings about the style. One way to workaround this 1000 lines warnings, we could disable this rule when we actually build, linter-check (see for instance https://github.com/apache/spark/commit/761fc46c70f15ffc3f35ff87b6a5c9192af1c55f). The Intellij actually looks useful to avoid excessive (and useless) string interpolation, which people still nitpick in PRs time to time. So, in this way, we could be able to the style only in IntelliJ and does not affect anything like build or existing codes. But not sure if guys here like this idea given the complexity, and .. 3.0.0 might be the last candidate to do this .. maybe at least with few years.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
