maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add
support to Decimal type for integral divide
URL: https://github.com/apache/spark/pull/25136#discussion_r315016918
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -384,7 +387,7 @@ case class Divide(left: Expression, right: Expression)
extends DivModLike {
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "expr1 _FUNC_ expr2 - Divide `expr1` by `expr2` rounded to the long
integer. It returns NULL if an operand is NULL or `expr2` is 0.",
+ usage = "expr1 _FUNC_ expr2 - Divide `expr1` by `expr2`. It returns NULL if
an operand is NULL or `expr2` is 0. The result is casted to long if
spark.sql.legacy.integralDivide.returnBigint is true, otherwise the datatype of
the operands is returned.",
Review comment:
Thanks for the update! nit: `datatype` -> `date type`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
