Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4120#discussion_r23337718
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -86,8 +86,12 @@ private[spark] class EventLoggingListener(
* Creates the log file in the configured log directory.
*/
def start() {
- if (!fileSystem.isDirectory(new Path(logBaseDir))) {
- throw new IllegalArgumentException(s"Log directory $logBaseDir does
not exist.")
+ try {
+ if (!fileSystem.getFileStatus(new Path(logBaseDir)).isDir()) {
+ throw new IllegalArgumentException(s"Log directory $logBaseDir is
not a directory.")
+ }
+ } catch {
+ case ioe: FileNotFoundException => fileSystem.mkdirs(new
Path(logBaseDir))
--- End diff --
Per @pwendell's earlier comment, I think we should check whether
`logBaseDir` already exists and log a warning if it's being automatically
created to let users know that it could potentially have wider directory
permissions than they intended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
