maropu commented on a change in pull request #25453: [SPARK-28730][SQL] 
Configurable type coercion policy for table insertion
URL: https://github.com/apache/spark/pull/25453#discussion_r315955141
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -2525,7 +2525,8 @@ class Analyzer(
     override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperators 
{
 
 Review comment:
   We might need to update the description for `ResolveOutputRelation` and 
refine "what's a safe cast?".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to