maryannxue commented on a change in pull request #25456: [SPARK-28739][SQL] Add 
a simple cost check for Adaptive Query Execution
URL: https://github.com/apache/spark/pull/25456#discussion_r316257936
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
 ##########
 @@ -152,17 +152,17 @@ class AdaptiveQueryExecSuite extends QueryTest with 
SharedSparkSession {
       val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(
         """
           |WITH t4 AS (
-          |  SELECT * FROM lowercaseData t2 JOIN testData3 t3 ON t2.n = t3.a
+          |  SELECT * FROM lowercaseData t2 JOIN testData3 t3 ON t2.n = t3.a 
where t2.n = '1'
 
 Review comment:
   Yeah, without this change, SMJ wouldn't be changed to BHJ because of the new 
cost guard.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to