rdblue commented on a change in pull request #25465: [SPARK-28747][SQL] merge
the two data source v2 fallback configs
URL: https://github.com/apache/spark/pull/25465#discussion_r316411681
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/FileDataSourceV2FallBackSuite.scala
##########
@@ -130,55 +130,9 @@ class FileDataSourceV2FallBackSuite extends QueryTest
with SharedSparkSession {
}
}
- test("Fall back to v1 when reading file with write only FileDataSourceV2") {
- val df = spark.range(10).toDF()
- withTempPath { file =>
- val path = file.getCanonicalPath
- // Dummy File writer should fail as expected.
Review comment:
Shouldn't this test always fall back to v1 as a result of the change? And
isn't that fallback what this was testing? I think this test should pass and
should still be valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
