Github user MickDavies commented on the pull request:
https://github.com/apache/spark/pull/4139#issuecomment-70984197
I've looked through ParquetQuerySuite and ParquetQuerySuite2 and its not
obvious that there are tests that will exercise this change. I.e. where Parquet
uses dictionary encoding for Strings. Most test String columns have strings
with incrementing values that will result in unique values, and I don't think
these will be encoded in dictionaries.
I think it would be good to add an explicit test to ParquetQuerySuite2,
which I'll try to do this evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
