srowen commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#discussion_r316469445
########## File path: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala ########## @@ -268,27 +268,19 @@ private[spark] class MesosCoarseGrainedSchedulerBackend( .getOrElse { throw new SparkException(s"Executor Spark home `$EXECUTOR_HOME` is not set!") } - val runScript = new File(executorSparkHome, "./bin/spark-class").getPath - command.setValue( - "%s \"%s\" org.apache.spark.executor.CoarseGrainedExecutorBackend" - .format(prefixEnv, runScript) + - s" --driver-url $driverURL" + - s" --executor-id $taskId" + - s" --hostname ${executorHostname(offer)}" + - s" --cores $numCores" + - s" --app-id $appId") + val executable = new File(executorSparkHome, "./bin/spark-class").getPath + val runScript = "%s \"%s\" org.apache.spark.executor.CoarseGrainedExecutorBackend" Review comment: Oh, you might need `${executable}` in this case, but it doesn't matter enough to bother with. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org