dongjoon-hyun commented on a change in pull request #25547:
[SPARK-28780][ML][2.4] deprecate LinearSVCModel.setWeightCol
URL: https://github.com/apache/spark/pull/25547#discussion_r316517662
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala
##########
@@ -313,7 +313,8 @@ class LinearSVCModel private[classification] (
setDefault(threshold, 0.0)
@Since("2.2.0")
- def setWeightCol(value: Double): this.type = set(threshold, value)
+ @deprecated("This method is deprecated and will be removed in the future.",
"2.4.4")
Review comment:
Nope. That's radical. We don't remove API in `maintenance` release. `3.0.0`
is natural for this kind of removal. I mean [the semantic
version](https://spark.apache.org/versioning-policy.html),
`major.minor.maintenance`.
> All releases with the same major version number will have API compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
