Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/4134#discussion_r23366593
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -349,34 +349,7 @@ class DAGScheduler(
}
private def getMissingParentStages(stage: Stage): List[Stage] = {
- val missing = new HashSet[Stage]
- val visited = new HashSet[RDD[_]]
- // We are manually maintaining a stack here to prevent
StackOverflowError
- // caused by recursively visiting
- val waitingForVisit = new Stack[RDD[_]]
- def visit(rdd: RDD[_]) {
- if (!visited(rdd)) {
- visited += rdd
- if (getCacheLocs(rdd).contains(Nil)) {
--- End diff --
Actually I don't fully understand why we need this. Does this mean the
`rdd` has at least one block which hasn't been cached? And why we need this to
get missing parent stages?
@lianhuiwang @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
