maropu commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316970632
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1805,9 +1805,9 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
- val ARITHMETIC_OPERATIONS_FAIL_ON_OVERFLOW =
- buildConf("spark.sql.arithmeticOperations.failOnOverFlow")
- .doc("If it is set to true, all arithmetic operations on non-decimal
fields throw an " +
+ val FAIL_ON_INTEGER_OVERFLOW =
+ buildConf("spark.sql.failOnIntegerOverFlow")
Review comment:
failOnIntegerOverFlow -> failOnIntegralTypeOverFlow? To me, Integer is a bit
ambiguous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
