dilipbiswal commented on a change in pull request #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r317171767
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala ########## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution + +import scala.collection.mutable +import scala.collection.mutable.ArrayBuffer + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.expressions.{Expression, PlanExpression} +import org.apache.spark.sql.catalyst.plans.QueryPlan +import org.apache.spark.sql.catalyst.trees.TreeNodeTag + +object ExplainUtils { + /** + * Given a input physical plan, performs the following tasks. + * 1. Computes the operator id for current operator and records it in the operaror + * by setting a tag. + * 2. Computes the whole stage codegen id for current operator and records it in the + * operator by setting a tag. + * 3. Generate the two part explain output for this plan. + * 1. First part explains the operator tree with each operator tagged with an unique + * identifier. + * 2. Second part explans each operator in a verbose manner. + * + * Note : This function skips over subqueries. They are handled by its caller. + * + * @param plan Input query plan to process + * @param append function used to append the explain output + * @param startOperationID The start value of operation id. The subsequent operations will + * be assigned higher value. + * + * @return The last generated operation id for this input plan. This is to ensure we + * always assign incrementing unique id to each operator. + * + */ + private def processPlanSkippingSubqueries[T <: QueryPlan[T]]( + plan: => QueryPlan[T], + append: String => Unit, + startOperatorID: Int): Int = { + + // ReusedSubqueryExecs are skipped over Review comment: @cloud-fan oh.. sorry.. thought you just wanted the comment changed. Let me see what i need to change further.. i remember i started with that and got into some issues.. and ended up with current code.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
