maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI
SQL: OVERLAY function support byte array
URL: https://github.com/apache/spark/pull/25172#discussion_r317594610
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
##########
@@ -141,6 +141,19 @@ class StringFunctionsSuite extends QueryTest with
SharedSQLContext {
// scalastyle:on
}
+ test("binary overlay function") {
+ // non ascii characters are not allowed in the code, so we disable the
scalastyle here.
Review comment:
This is just a confirmation; have you checked if the other databases (e.g.,
postgresql, oracle, ..) have the same output?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
