gaborgsomogyi commented on a change in pull request #22138: [SPARK-25151][SS]
Apply Apache Commons Pool to KafkaDataConsumer
URL: https://github.com/apache/spark/pull/22138#discussion_r318047563
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaDataConsumerSuite.scala
##########
@@ -121,4 +125,158 @@ class KafkaDataConsumerSuite extends SharedSparkSession
with PrivateMethodTester
threadpool.shutdown()
}
}
+
+ test("SPARK-25151 Handles multiple tasks in executor fetching same (topic,
partition) pair") {
Review comment:
I've read back the discussion and now see the point. I still think it looks
weird and can be added as comment but let's leave this part to the person who
will do the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
