Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4158#discussion_r23444792
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala
---
@@ -54,23 +55,47 @@ case class ScriptTransformation(
val outputStream = proc.getOutputStream
val reader = new BufferedReader(new InputStreamReader(inputStream))
+ // This projection outputs to the script, which runs in a single
process
+ // TODO a Writer SerDe will be placed here.
+ val inputProjection = new InterpretedProjection(input, child.output)
+
+ // This projection is casting the scripts output into user specified
data type
+ // TODO a Reader SerDe will be placed here for the casting the output
+ // data type into the required one
+ val outputProjection = new
InterpretedProjection(output.zipWithIndex.map {
+ case (attr, idx) => if (attr.dataType == StringType) {
+ BoundReference(idx, StringType, true)
--- End diff --
`BoundReference` can be out of the if block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
