cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318411372
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ########## @@ -216,6 +216,35 @@ object SQLConf { .booleanConf .createWithDefault(true) + val DYNAMIC_PARTITION_PRUNING_ENABLED = + buildConf("spark.sql.optimizer.dynamicPartitionPruning.enabled") + .doc("When true, we will generate predicate for partition column when it's used as join key") + .booleanConf + .createWithDefault(true) + + val DYNAMIC_PARTITION_PRUNING_WITH_STATS = + buildConf("spark.sql.optimizer.dynamicPartitionPruningWithStats") Review comment: shall we put all the related configs in the same namespace? e.g. `spark.sql.optimizer.dynamicPartitionPruning.withStats`, `spark.sql.optimizer.dynamicPartitionPruning.joinFilterRatio`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org