cloud-fan commented on a change in pull request #25104: [SPARK-28341][SQL]
create a public API for V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#discussion_r319111295
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -39,20 +39,18 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
/**
* A [[TableCatalog]] that translates calls to the v1 SessionCatalog.
*/
-class V2SessionCatalog(sessionState: SessionState) extends TableCatalog {
+class V2SessionCatalog(catalog: SessionCatalog, conf: SQLConf) extends
TableCatalog {
Review comment:
This change is necessary. We create `V2SessionCatalog` in
`BaseSessionStateBuilder`, where there is no `SessionState` instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
