cloud-fan commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r319122843
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
##########
@@ -79,9 +81,9 @@ private[spark] class SortShuffleManager(conf: SparkConf)
extends ShuffleManager
}
/**
- * A mapping from shuffle ids to the number of mappers producing output for
those shuffles.
+ * A mapping from shuffle ids to the task ids of mappers producing output
for those shuffles.
*/
- private[this] val numMapsForShuffle = new ConcurrentHashMap[Int, Int]()
+ private[this] val taskIdMapsForShuffle = new ConcurrentHashMap[Int,
ArrayBuffer[Long]]()
Review comment:
mostly it's hundreds or thousands of mappers, which is about several KB. I
think it's fine. If there are many many mappers, our DAG scheduler will burn
out first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
