HyukjinKwon commented on a change in pull request #25628:
[SPARK-28897][Core]'coalesce' error when executing dataframe.na.fill
URL: https://github.com/apache/spark/pull/25628#discussion_r319461063
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala
##########
@@ -435,11 +435,10 @@ final class DataFrameNaFunctions private[sql](df:
DataFrame) {
* Returns a [[Column]] expression that replaces null value in `col` with
`replacement`.
*/
private def fillCol[T](col: StructField, replacement: T): Column = {
- val quotedColName = "`" + col.name + "`"
Review comment:
Seems like it doesn't support special characters in the column name now. Can
we keep the support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
