Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4073#issuecomment-71338606
@MechCoder This is an addition instead of a correction, but I just
realized that Strategy.assertValid() does not check subsamplingRate. Would you
mind adding that check? The rest looks good to me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
